Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay adding helper method to on_load #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benningm
Copy link

@benningm benningm commented Aug 5, 2019

Autoloading within initilizers is deprecated in rails 6.0.

Adding helper method to ActionController::Base during initialization
will trigger autoloading it.

This delays adding the helper methods using an on_load() hook for
all rails version >= 6.

Autoloading within initilizers is deprecated in rails 6.0.

Adding helper method to ActionController::Base during initialization
will trigger autoloading it.

This delays adding the helper methods using an on_load() hook for
all rails version >= 6.
@jbeker
Copy link

jbeker commented May 19, 2020

Is there any chance this will get merged?

@jasonperrone
Copy link

I second the question from @jbeker

Th0t added a commit to Th0t/rails-jquery-autocomplete that referenced this pull request Oct 23, 2020
@jasonperrone
Copy link

This gem is on the verge of becoming useless when Rails 6.2 is released because of this.

BenMcH added a commit to BenMcH/rails-jquery-autocomplete that referenced this pull request Aug 25, 2021
Full credit for this patch goes to benningm at this PR: risuiowa#105

The original author has not merged this PR in 2 years, so I am making this patch as to not be a blocker for rails 6 projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants